Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Extract all NE resources from the zip file #2477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MNT: Extract all NE resources from the zip file #2477

wants to merge 1 commit into from

Conversation

greglucas
Copy link
Contributor

Rationale

The various Natural Earth datasets can have different file members within them. Rather than explicitly iterating through the list of expected files, lets just extract all of them. This adds a datasetname.README.txt and datasetname.VERSION.txt which could be helpful for debugging purposes too and the sizes are very small for the extra files.

closes #2319

Implications

@greglucas
Copy link
Contributor Author

This is failing because we allow the renaming of file contents when extracting an archive. The content within the zipfile is: ne_110m_rivers_lake_centerlines.shp, but the download template wants to rename that to: {category}_{resolution}_{name}.shp. I'm not sure I fully agree with the ability to rename a file coming from an archive, versus making the reader handle different formatted filenames, but I do sort of see why you may want to do that to try and organize things your own way too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Raster source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key Error using Natural Earth POV files
1 participant
@greglucas